Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe qrexec-client(-vm) --help output to stdout #179

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

alimirjamali
Copy link
Contributor

Help is output to stderr at the moment

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (157da6f) to head (abe8eb5).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
agent/qrexec-client-vm.c 0.00% 12 Missing ⚠️
daemon/qrexec-client.c 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   78.98%   78.91%   -0.08%     
==========================================
  Files          54       54              
  Lines        9740     9740              
==========================================
- Hits         7693     7686       -7     
- Misses       2047     2054       +7     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alimirjamali
Copy link
Contributor Author

Notes: I can not locate the proper unittest to update. Guidance is appreciated.

daemon/qrexec-client.c Outdated Show resolved Hide resolved
agent/qrexec-client-vm.c Show resolved Hide resolved
Help is output to stderr at the moment
@marmarek marmarek merged commit 37f5f14 into QubesOS:main Oct 10, 2024
2 of 4 checks passed
@alimirjamali alimirjamali deleted the qrexec-client branch October 29, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants